[
https://issues.apache.org/jira/browse/SHINDIG-1637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125864#comment-13125864
]
[email protected] commented on SHINDIG-1637:
--------------------------------------------------------
bq. On 2011-10-12 12:19:00, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java,
line 55
bq. > <https://reviews.apache.org/r/2333/diff/2/?file=49558#file49558line55>
bq. >
bq. > This probably isn't very expensive to pull stuff from the config
since it is already in memory but instead of calling config.getBool in the loop
every time you could assign it to a local variable above and just call it once
config.getBool takes the container and that's what we're looping over, so it
can't be pulled out.
- Stanton
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2333/#review2530
-----------------------------------------------------------
On 2011-10-12 14:00:29, Stanton Sievers wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2333/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-12 14:00:29)
bq.
bq.
bq. Review request for Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. The proposed changes are to introduce an abstract class that implements
LockedDomainService and provides some infrastructure to make creating one's own
LockedDomainService a bit easier.
bq.
bq. Sorry for the horrible diffs. I moved a lot of stuff around in
HashLockedDomainService.
bq.
bq.
bq. This addresses bug SHINDIG-1637.
bq. https://issues.apache.org/jira/browse/SHINDIG-1637
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
1181021
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/LockedDomainService.java
1181021
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/HashLockedDomainServiceTest.java
1181021
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RendererTest.java
1181021
bq.
bq. Diff: https://reviews.apache.org/r/2333/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated and ran existing JUnits.
bq.
bq.
bq. Thanks,
bq.
bq. Stanton
bq.
bq.
> Introduce abstract LockedDomainService implementation to enable easier
> customization
> ------------------------------------------------------------------------------------
>
> Key: SHINDIG-1637
> URL: https://issues.apache.org/jira/browse/SHINDIG-1637
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 3.0.0
> Reporter: Stanton Sievers
> Priority: Minor
> Fix For: 3.0.0
>
> Original Estimate: 72h
> Remaining Estimate: 72h
>
> Currently when one wants to created a customized LockedDomainService, one has
> to implement all of the functionality from scratch. The proposed changes are
> to introduce an abstract class that implements LockedDomainService and
> provides some infrastructure to make creating one's own LockedDomainService a
> bit easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
