[
https://issues.apache.org/jira/browse/SHINDIG-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137548#comment-13137548
]
[email protected] commented on SHINDIG-1652:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2576/
-----------------------------------------------------------
(Updated 2011-10-27 21:05:02.721746)
Review request for shindig, Ryan Baxter and Dan Dumont.
Changes
-------
new patch. We do check the object before adding to the array, so Dan's
suggestion works fine.
Summary
-------
IE8 doesn't support both "forEach" and "indexOf" Javascript methods, replace
these methods with for loop.
This addresses bug SHINDIG-1652.
https://issues.apache.org/jira/browse/SHINDIG-1652
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1189339
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
1189339
Diff: https://reviews.apache.org/r/2576/diff
Testing
-------
Test it with the sample container in IE8
Thanks,
Jason
> Selection service deesn't work correctly in IE8
> -----------------------------------------------
>
> Key: SHINDIG-1652
> URL: https://issues.apache.org/jira/browse/SHINDIG-1652
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 3.0.0
> Environment: IE8
> Reporter: Jason Chiang
> Original Estimate: 4h
> Remaining Estimate: 4h
>
> IE8 doesn't support Javascript forEach method
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
