[ 
https://issues.apache.org/jira/browse/SHINDIG-1652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138513#comment-13138513
 ] 

[email protected] commented on SHINDIG-1652:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2576/#review2907
-----------------------------------------------------------

Ship it!


Committed revision 1190438.

- Ryan


On 2011-10-27 21:05:02, Jason Chiang wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2576/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-27 21:05:02)
bq.  
bq.  
bq.  Review request for shindig, Ryan Baxter and Dan Dumont.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  IE8 doesn't support both "forEach" and "indexOf" Javascript methods, 
replace these methods with for loop.
bq.  
bq.  
bq.  This addresses bug SHINDIG-1652.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1652
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
 1189339 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection_container.js
 1189339 
bq.  
bq.  Diff: https://reviews.apache.org/r/2576/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Test it with the sample container in IE8
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Jason
bq.  
bq.


                
> Selection service deesn't work correctly in IE8
> -----------------------------------------------
>
>                 Key: SHINDIG-1652
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1652
>             Project: Shindig
>          Issue Type: Bug
>          Components: Javascript 
>    Affects Versions: 3.0.0
>         Environment: IE8
>            Reporter: Jason Chiang
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> IE8 doesn't support Javascript forEach method

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to