[
https://issues.apache.org/jira/browse/SHINDIG-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141179#comment-13141179
]
[email protected] commented on SHINDIG-1646:
--------------------------------------------------------
bq. On 2011-10-31 02:09:02, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js,
line 609
bq. > <https://reviews.apache.org/r/2525/diff/2/?file=53449#file53449line609>
bq. >
bq. > I believe there is a function int he container utils to give you the
current ms, probably want to use that
Ok, but it seems silly to have a function for that... It probably gets
inlined by closure anyway.
bq. On 2011-10-31 02:09:02, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java,
line 544
bq. > <https://reviews.apache.org/r/2525/diff/2/?file=53458#file53458line544>
bq. >
bq. > Seems like it might make sense to update the unit tests which
validate the info returned in the metadata request to check for the ttl.
ok
bq. On 2011-10-31 02:09:02, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js,
line 225
bq. > <https://reviews.apache.org/r/2525/diff/2/?file=53449#file53449line225>
bq. >
bq. > Are there any cases where the token TTL would not be returned in the
metadata? I assume not...
I'll put a check in the called method just in case.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2525/#review2935
-----------------------------------------------------------
On 2011-10-26 17:46:48, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2525/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-10-26 17:46:48)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This change adds the token TTL to the metadata request for a gadget
needing token refresh.
bq. The container uses the token's ttl to manage the refresh cycle of tokens.
bq.
bq. Refresh cycle impl was changed from setInterval to setTimeout because if
intervals are missed due to inability to schedule them
(suspend/sleep/hibernate/busy)
bq. they will *all* be executed in order when able.
bq.
bq. A few TODO's in the code I did not have time to address.
bq. One is configurable token TTL values via ContainerConfig. Another is
better managing refresh cycle when using tokens any of which may have varying
expirations.
bq.
bq.
bq. This addresses bug SHINDIG-1646.
bq. https://issues.apache.org/jira/browse/SHINDIG-1646
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AbstractSecurityToken.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenCodec.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/UrlParameterAuthenticationHandlerTest.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/testing/FakeGadgetToken.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1189191
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1189191
bq.
bq. Diff: https://reviews.apache.org/r/2525/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tests updated to cope with interface changes. All tests pass.
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Put token expiration in ContainerConfig and provide token expirys in metadata
> responses so the common container can decide when to expire tokens correctly.
> -----------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1646
> URL: https://issues.apache.org/jira/browse/SHINDIG-1646
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Attachments: upstream.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
