[
https://issues.apache.org/jira/browse/SHINDIG-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13141259#comment-13141259
] [email protected] commented on SHINDIG-1646: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2525/ ----------------------------------------------------------- (Updated 2011-11-01 15:51:26.414131) Review request for shindig. Changes ------- Updated with changes from Ryan's feedback. Summary ------- This change adds the token TTL to the metadata request for a gadget needing token refresh. The container uses the token's ttl to manage the refresh cycle of tokens. Refresh cycle impl was changed from setInterval to setTimeout because if intervals are missed due to inability to schedule them (suspend/sleep/hibernate/busy) they will *all* be executed in order when able. A few TODO's in the code I did not have time to address. One is configurable token TTL values via ContainerConfig. Another is better managing refresh cycle when using tokens any of which may have varying expirations. This addresses bug SHINDIG-1646. https://issues.apache.org/jira/browse/SHINDIG-1646 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1195992 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js 1195992 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AbstractSecurityToken.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityTokenCodec.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityTokenCodec.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/DefaultSecurityTokenCodec.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityTokenCodec.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/auth/UrlParameterAuthenticationHandlerTest.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/test/java/org/apache/shindig/common/testing/FakeGadgetToken.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java 1195992 http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java 1195992 Diff: https://reviews.apache.org/r/2525/diff Testing ------- Tests updated to cope with interface changes. All tests pass. Thanks, Dan > Put token expiration in ContainerConfig and provide token expirys in metadata > responses so the common container can decide when to expire tokens correctly. > ----------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: SHINDIG-1646 > URL: https://issues.apache.org/jira/browse/SHINDIG-1646 > Project: Shindig > Issue Type: Improvement > Reporter: Dan Dumont > Attachments: upstream.patch > > -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
