[
https://issues.apache.org/jira/browse/SHINDIG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146342#comment-13146342
]
[email protected] commented on SHINDIG-1653:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2616/#review3105
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
<https://reviews.apache.org/r/2616/#comment6912>
Is there harm in setting this if it *is* undefined?
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
<https://reviews.apache.org/r/2616/#comment6913>
Can you check truthy here?
if (this.gadgetLoadedCallback_)
Empty string is falsey in js, you don't need to explicitly check for it.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
<https://reviews.apache.org/r/2616/#comment6914>
Can you use double quotes to quote the single quote strings?
"({'" + blah + "':'"
That could eliminate all of those slashes.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
<https://reviews.apache.org/r/2616/#comment6915>
Again, is truthiness something that you can use here instead of the typeof
and emptystring check?
- Dan
On 2011-11-01 23:49:25, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2616/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-01 23:49:25)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. We already have a callback function for navigating gadgets in the common
container which can be used to print timing information. Problem is if you
preload the gadget before navigating the timing information during navigation
is 0. It would be helpful to print timing information for preloading as well.
bq.
bq.
bq. This addresses bug SHINDIG-1653.
bq. https://issues.apache.org/jira/browse/SHINDIG-1653
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/container_test.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_site_test.js
1190425
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/util_test.js
1190425
bq.
bq. Diff: https://reviews.apache.org/r/2616/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Modified sample container to log this information and updated unit tests.
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Add callback function to print timing information for gadget preloading.
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1653
> URL: https://issues.apache.org/jira/browse/SHINDIG-1653
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Priority: Minor
> Original Estimate: 3h
> Remaining Estimate: 3h
>
> We already have a callback function for navigating gadgets in the common
> container which can be used to print timing information. Problem is if you
> preload the gadget before navigating the timing information during navigation
> is 0. It would be helpful to print timing information for preloading as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
