[
https://issues.apache.org/jira/browse/SHINDIG-1653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153135#comment-13153135
] [email protected] commented on SHINDIG-1653: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2616/ ----------------------------------------------------------- (Updated 2011-11-18 21:16:31.247556) Review request for shindig. Changes ------- Updated description Summary (updated) ------- I have added additional lifecycle handlers. My primary use case here is to be able to time the different events that take place as a gadget is rendered, but these additional lifecycle handlers may be used for other things as well. This addresses bug SHINDIG-1653. https://issues.apache.org/jira/browse/SHINDIG-1653 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensearch/opensearch.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shared-script-frame/shared-script-frame-container.js 1203746 http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js 1203746 Diff: https://reviews.apache.org/r/2616/diff Testing ------- Modified sample container to log this information and updated unit tests. Thanks, Ryan > Add callback function to print timing information for gadget preloading. > ------------------------------------------------------------------------ > > Key: SHINDIG-1653 > URL: https://issues.apache.org/jira/browse/SHINDIG-1653 > Project: Shindig > Issue Type: Improvement > Affects Versions: 3.0.0 > Reporter: Ryan Baxter > Priority: Minor > Original Estimate: 3h > Remaining Estimate: 3h > > We already have a callback function for navigating gadgets in the common > container which can be used to print timing information. Problem is if you > preload the gadget before navigating the timing information during navigation > is 0. It would be helpful to print timing information for preloading as well. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
