[
https://issues.apache.org/jira/browse/SHINDIG-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185624#comment-13185624
]
[email protected] commented on SHINDIG-1681:
--------------------------------------------------------
bq. On 2012-01-12 23:25:46, Ryan Baxter wrote:
bq. > Looks like you added some additional methods to gadget site and
container util, do you want to also make the corresponding changes in the
feature.xml files as well?
I think I've declared all of the ones I wanted to be public in the features.xml.
That file is just to assist in exports and closure process, right? Or do all
methods used in other files need to be called out there?
bq. On 2012-01-12 23:25:46, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js,
line 84
bq. > <https://reviews.apache.org/r/3180/diff/9/?file=67635#file67635line84>
bq. >
bq. > Maybe I am missing something here but you seem to be saying you can
pass in the module id in args but here you are setting it to 0 instead of
checking if its in the args
Whoops. I'll edit that comment.
- Dan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3180/#review4339
-----------------------------------------------------------
On 2012-01-10 20:53:59, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3180/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-10 20:53:59)
bq.
bq.
bq. Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse
Ciancetta, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial review of 1st change. Allowing common container to manage
container token refreshes. Also, refresh of gadget security tokens will now
wait for valid container security token before trying to refresh.
bq.
bq.
bq. This addresses bug SHINDIG-1681.
bq. https://issues.apache.org/jira/browse/SHINDIG-1681
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/feature.xml
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/service_test.js
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ModuleIdManager.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ModuleIdManagerImpl.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1222407
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1222407
bq.
bq. Diff: https://reviews.apache.org/r/3180/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested code in a private container with some examples of setting no
refresh (ttl = 0) and setting an initial token (if it was written by jsp page
to avoid transaction) etc..
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Implement Container token Refresh and moduleId capability for gadget tokens.
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1681
> URL: https://issues.apache.org/jira/browse/SHINDIG-1681
> Project: Shindig
> Issue Type: New Feature
> Components: Java, Javascript
> Reporter: Dan Dumont
>
> Provides a refresh mechanism in the container for the container token and
> placeholders for implementing a gadget instance persistence mechanism that
> utilizes moduleIds in gadget security tokens.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
