[
https://issues.apache.org/jira/browse/SHINDIG-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13185717#comment-13185717
]
[email protected] commented on SHINDIG-1681:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3180/#review4362
-----------------------------------------------------------
Ship it!
Committed r1231211.
Thanks everyone for the reviews!
- Dan
On 2012-01-13 16:44:45, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3180/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-13 16:44:45)
bq.
bq.
bq. Review request for shindig, Henry Saputra, Ryan Baxter, li xu, Jesse
Ciancetta, and Stanton Sievers.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Initial review of 1st change. Allowing common container to manage
container token refreshes. Also, refresh of gadget security tokens will now
wait for valid container security token before trying to refresh.
bq.
bq.
bq. This addresses bug SHINDIG-1681.
bq. https://issues.apache.org/jira/browse/SHINDIG-1681
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/assembler.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_holder.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.gadget/gadget_site.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/constant.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/feature.xml
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.util/util.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/feature.xml
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/service.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/gadget_holder_test.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/container/service_test.js
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandler.java
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerApi.java
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerService.java
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ModuleIdManager.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ModuleIdManagerImpl.java
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerServiceTest.java
1231165
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/GadgetsHandlerTest.java
1231165
bq.
bq. Diff: https://reviews.apache.org/r/3180/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested code in a private container with some examples of setting no
refresh (ttl = 0) and setting an initial token (if it was written by jsp page
to avoid transaction) etc..
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Implement Container token Refresh and moduleId capability for gadget tokens.
> ----------------------------------------------------------------------------
>
> Key: SHINDIG-1681
> URL: https://issues.apache.org/jira/browse/SHINDIG-1681
> Project: Shindig
> Issue Type: New Feature
> Components: Java, Javascript
> Reporter: Dan Dumont
> Attachments: shindig.patch
>
>
> Provides a refresh mechanism in the container for the container token and
> placeholders for implementing a gadget instance persistence mechanism that
> utilizes moduleIds in gadget security tokens.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
