[
https://issues.apache.org/jira/browse/SHINDIG-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195106#comment-13195106
]
[email protected] commented on SHINDIG-1690:
--------------------------------------------------------
bq. On 2012-01-27 21:00:21, Ryan Baxter wrote:
bq. >
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js,
line 166
bq. > <https://reviews.apache.org/r/3668/diff/1/?file=71118#file71118line166>
bq. >
bq. > usually keys from the spec start with org.opensocial.*, we should
probably follow the same pattern
bq.
bq. Dan Dumont wrote:
bq. Ok. I've no opinion about this key lives. I (or someone) can move it
when the spec for this feature is decided upon, if this is the agreed upon
approach.
If we know it is going to start with org.opensocial why not change it to match
so we dont have to change it later. Something like org.opensocial.selection
should work. For example for embedded experiences we use
org.opensocial.ee.context.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3668/#review4658
-----------------------------------------------------------
On 2012-01-27 20:52:24, Dan Dumont wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3668/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-27 20:52:24)
bq.
bq.
bq. Review request for shindig and Andrew Davis.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This review is mostly for Mark.
bq.
bq. Hopefully this change will supply the template code with all it needs to
work with selection. A good starting point at least.
bq.
bq.
bq. This addresses bug SHINDIG-1690.
bq. https://issues.apache.org/jira/browse/SHINDIG-1690
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
1236266
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
1236266
bq.
bq. Diff: https://reviews.apache.org/r/3668/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Built fine, all tests pass. I don't have any gadgets to run against right
now. Hoping to have Mark try it out. (you don't seem to have an account on
here, Mark. I couldn't add you as a reviewer)
bq.
bq.
bq. Thanks,
bq.
bq. Dan
bq.
bq.
> Publish global selection into the DataContext of a gadget (if available)
> -------------------------------------------------------------------------
>
> Key: SHINDIG-1690
> URL: https://issues.apache.org/jira/browse/SHINDIG-1690
> Project: Shindig
> Issue Type: Improvement
> Reporter: Dan Dumont
> Priority: Minor
>
> This should make global selection available to templates.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
