[ 
https://issues.apache.org/jira/browse/SHINDIG-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13195113#comment-13195113
 ] 

[email protected] commented on SHINDIG-1690:
--------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3668/
-----------------------------------------------------------

(Updated 2012-01-27 21:12:09.770883)


Review request for shindig and Andrew Davis.


Changes
-------

Ryan, I thought you had meant the constant name, not the key name.   Fixed.


Summary
-------

This review is mostly for Mark.

Hopefully this change will supply the template code with all it needs to work 
with selection.   A good starting point at least.


This addresses bug SHINDIG-1690.
    https://issues.apache.org/jira/browse/SHINDIG-1690


Diffs (updated)
-----

  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/opensocial-data-context/datacontext.js
 1236266 
  
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/selection/selection.js
 1236266 

Diff: https://reviews.apache.org/r/3668/diff


Testing
-------

Built fine, all tests pass.  I don't have any gadgets to run against right now. 
  Hoping to have Mark try it out.   (you don't seem to have an account on here, 
Mark.  I couldn't add you as a reviewer)


Thanks,

Dan


                
> Publish global selection into the DataContext of a gadget (if available) 
> -------------------------------------------------------------------------
>
>                 Key: SHINDIG-1690
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1690
>             Project: Shindig
>          Issue Type: Improvement
>            Reporter: Dan Dumont
>            Priority: Minor
>
> This should make global selection available to templates.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to