[ 
https://issues.apache.org/jira/browse/SHINDIG-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13202753#comment-13202753
 ] 

Henry Saputra commented on SHINDIG-1701:
----------------------------------------

CR: https://reviews.apache.org/r/3777
                
> Change the action_container.js rpc registration to call the 
> Container.rpcRegister instead directly call gadgets.rpc.register
> ----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SHINDIG-1701
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1701
>             Project: Shindig
>          Issue Type: Improvement
>          Components: Javascript 
>    Affects Versions: 3.0.0
>            Reporter: Henry Saputra
>            Assignee: Henry Saputra
>
> The actions feature for the container side register rpc callback via 
> gadgets.rpc.register. However, since the rpc handler actually happen in the 
> container its preferable to use the action_container.js rpc registration to 
> call the Container.rpcRegister instead directly call gadgets.rpc.register.
> The osapi.container.Container.prototype.rpcRegister has special code to 
> inject "gs" key to include the caller gadget site.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to