[
https://issues.apache.org/jira/browse/SHINDIG-1701?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13203191#comment-13203191
]
[email protected] commented on SHINDIG-1701:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3777/#review4892
-----------------------------------------------------------
Ship it!
LGTM
- Ryan
On 2012-02-07 22:41:01, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3777/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-07 22:41:01)
bq.
bq.
bq. Review request for shindig, Ryan Baxter and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. See jira https://issues.apache.org/jira/browse/SHINDIG-1701
bq.
bq.
bq. This addresses bug SHINDIG-1701.
bq. https://issues.apache.org/jira/browse/SHINDIG-1701
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/features/src/main/javascript/features/actions/actions_container.js
1241570
bq.
bq. Diff: https://reviews.apache.org/r/3777/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Run mvn clean install and sanity test with conservcontainer
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Change the action_container.js rpc registration to call the
> Container.rpcRegister instead directly call gadgets.rpc.register
> ----------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1701
> URL: https://issues.apache.org/jira/browse/SHINDIG-1701
> Project: Shindig
> Issue Type: Improvement
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Henry Saputra
> Assignee: Henry Saputra
>
> The actions feature for the container side register rpc callback via
> gadgets.rpc.register. However, since the rpc handler actually happen in the
> container its preferable to use the action_container.js rpc registration to
> call the Container.rpcRegister instead directly call gadgets.rpc.register.
> The osapi.container.Container.prototype.rpcRegister has special code to
> inject "gs" key to include the caller gadget site.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
