[
https://issues.apache.org/jira/browse/SHINDIG-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209766#comment-13209766
]
[email protected] commented on SHINDIG-1708:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3936/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
In core.log the private _console var is set when the javascript is evaluated in
the page. If you are providing your own instance of the console object than the
object might not be created when this javascript is evaluated. A better
approach is to set the private _console var the first time anything is logged.
This gives other javascript a chance to load into the page before we set this
variable.
This addresses bug SHINDIG-1708.
https://issues.apache.org/jira/browse/SHINDIG-1708
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.log/log.js
1245178
Diff: https://reviews.apache.org/r/3936/diff
Testing
-------
All unit tests pass and tested in containers
Thanks,
Ryan
> core.log sets the _console var when the javascript is loaded in the page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1708
> URL: https://issues.apache.org/jira/browse/SHINDIG-1708
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
>
> In core.log the private _console var is set when the javascript is evaluated
> in the page. If you are providing your own instance of the console object
> than the object might not be created when this javascript is evaluated. A
> better approach is to set the private _console var the first time anything is
> logged. This gives other javascript a chance to load into the page before we
> set this variable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
