[
https://issues.apache.org/jira/browse/SHINDIG-1708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13209833#comment-13209833
]
[email protected] commented on SHINDIG-1708:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3936/#review5173
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-02-16 21:42:09, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3936/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-02-16 21:42:09)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In core.log the private _console var is set when the javascript is
evaluated in the page. If you are providing your own instance of the console
object than the object might not be created when this javascript is evaluated.
A better approach is to set the private _console var the first time anything is
logged. This gives other javascript a chance to load into the page before we
set this variable.
bq.
bq.
bq. This addresses bug SHINDIG-1708.
bq. https://issues.apache.org/jira/browse/SHINDIG-1708
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.log/log.js
1245178
bq.
bq. Diff: https://reviews.apache.org/r/3936/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. All unit tests pass and tested in containers
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> core.log sets the _console var when the javascript is loaded in the page
> ------------------------------------------------------------------------
>
> Key: SHINDIG-1708
> URL: https://issues.apache.org/jira/browse/SHINDIG-1708
> Project: Shindig
> Issue Type: Bug
> Reporter: Ryan Baxter
>
> In core.log the private _console var is set when the javascript is evaluated
> in the page. If you are providing your own instance of the console object
> than the object might not be created when this javascript is evaluated. A
> better approach is to set the private _console var the first time anything is
> logged. This gives other javascript a chance to load into the page before we
> set this variable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
