[
https://issues.apache.org/jira/browse/SHINDIG-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ryan Baxter updated SHINDIG-1712:
---------------------------------
Description:
There are several things that need to be cleaned up.
1. Recent changes to how RPC handlers are handled broke the RPC handler
functions. Changes in the context in which the functions are run changed the
value of this.
2. Timing issues in sample gadget caused javascript errors when closing
dialogs.
3. When closing a dialog without pressing cancel or ok caused osapi errors
because there was no media item to update.
4. Use of console.log instead of using gadgets.log in sample gadget
5. Always pass the relative element whenever the gadgets.views.open* APIs are
called.
6. Pass the gadget metadata to createElementForEmbeddedExperience when the EE
data model has a gadget in it.
was:When creating a gadget calls gadgets.views.openEmbeddedExperience the
container will be asked to create the chrome of the view target they want to
open. Currently the container is not given the context of the EE data model,
which can be useful to the container when creating the view. For example the
container could preload the gadget at that point in order to get the metadata
to put a title in the dialog.
Summary: Cleanup open view APIs (was:
osapi.container.view.createElementForEmbeddedExperience does not get passed the
embedded experience context informaiton)
> Cleanup open view APIs
> ----------------------
>
> Key: SHINDIG-1712
> URL: https://issues.apache.org/jira/browse/SHINDIG-1712
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> There are several things that need to be cleaned up.
> 1. Recent changes to how RPC handlers are handled broke the RPC handler
> functions. Changes in the context in which the functions are run changed the
> value of this.
> 2. Timing issues in sample gadget caused javascript errors when closing
> dialogs.
> 3. When closing a dialog without pressing cancel or ok caused osapi errors
> because there was no media item to update.
> 4. Use of console.log instead of using gadgets.log in sample gadget
> 5. Always pass the relative element whenever the gadgets.views.open* APIs
> are called.
> 6. Pass the gadget metadata to createElementForEmbeddedExperience when the
> EE data model has a gadget in it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
