[
https://issues.apache.org/jira/browse/SHINDIG-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218742#comment-13218742
]
[email protected] commented on SHINDIG-1712:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4077/
-----------------------------------------------------------
(Updated 2012-02-28 22:28:58.031719)
Review request for shindig, Henry Saputra, Dan Dumont, and Igor Belakovskiy.
Changes
-------
Updated based on Henry's feedback
Summary
-------
1. Recent changes to how RPC handlers are handled broke the RPC handler
functions. Changes in the context in which the functions are run changed the
value of this.
2. Timing issues in sample gadget caused javascript errors when closing
dialogs.
3. When closing a dialog without pressing cancel or ok caused osapi errors
because there was no media item to update.
4. Use of console.log instead of using gadgets.log in sample gadget
5. Always pass the relative element whenever the gadgets.views.open* APIs are
called.
6. Pass the gadget metadata to createElementForEmbeddedExperience when the EE
data model has a gadget in it.
This addresses bug SHINDIG-1712.
https://issues.apache.org/jira/browse/SHINDIG-1712
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js
1294283
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js
1294283
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/PhotoList.xml
1294283
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/embeddedexperiences/index.html
1294283
http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/media-openGadgets/MediaUIOpenGadgets.js
1294283
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js
1294283
Diff: https://reviews.apache.org/r/4077/diff
Testing
-------
Testing in various containers
Thanks,
Ryan
> Cleanup open view APIs
> ----------------------
>
> Key: SHINDIG-1712
> URL: https://issues.apache.org/jira/browse/SHINDIG-1712
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
>
> There are several things that need to be cleaned up.
> 1. Recent changes to how RPC handlers are handled broke the RPC handler
> functions. Changes in the context in which the functions are run changed the
> value of this.
> 2. Timing issues in sample gadget caused javascript errors when closing
> dialogs.
> 3. When closing a dialog without pressing cancel or ok caused osapi errors
> because there was no media item to update.
> 4. Use of console.log instead of using gadgets.log in sample gadget
> 5. Always pass the relative element whenever the gadgets.views.open* APIs
> are called.
> 6. Pass the gadget metadata to createElementForEmbeddedExperience when the
> EE data model has a gadget in it.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
