[
https://issues.apache.org/jira/browse/SHINDIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221205#comment-13221205
]
[email protected] commented on SHINDIG-1719:
--------------------------------------------------------
bq. On 2012-03-02 12:52:49, Stanton Sievers wrote:
bq. > Hi Henry,
bq. >
bq. > You should also remove the logic in
org.apache.shindig.auth.BlobCrypterSecurityToken.fromToken(SecurityToken) where
we eat the UnsupportedOperationException when calling getActiveUrl().
bq. >
bq. > I'm also looking at
org.apache.shindig.gadgets.oauth.GadgetOAuthCallbackGenerator.checkGadgetCanRender(SecurityToken,
OAuthArguments, OAuthResponseParams) and it seems like a value of "null" here
is going to throw other exceptions when create a Uri.parse. I'm wondering if
we can handle "null" more gracefully here... although we really weren't
handling UnsupportedOperationException gracefully here either.
bq. >
bq. > Do you know why the exception was being thrown in the first place?
Looking at the rest of the APIs in SecurityToken that one strikes me as odd.
Thanks for the BlobCrypterSecurityToken.fromToken change.
Yeah, I am aware of the checkGadgetCanRender call. I wouldnt worry about it tho
bc most of times the UrlParameterAuthenticationHandler should do its job to
inject the right activeUrl to the token.
- Henry
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4135/#review5556
-----------------------------------------------------------
On 2012-03-01 23:38:41, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4135/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-01 23:38:41)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Simplify the SecurityToken.getActiveUrl implementation and definition.
bq.
bq. If not set simply return null should be suffice.
bq.
bq.
bq. This addresses bug SHINDIG-1719.
bq. https://issues.apache.org/jira/browse/SHINDIG-1719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityToken.java
1295758
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java
1295758
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityToken.java
1295758
bq.
bq. Diff: https://reviews.apache.org/r/4135/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Remove throwing UnsupportedOperationException with call to
> BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1719
> URL: https://issues.apache.org/jira/browse/SHINDIG-1719
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Henry Saputra
> Priority: Minor
> Labels: security_token, shidnig
>
> I dont see any value throwing UnsupportedOperationException in calling
> getActiveUrl method in basic and blob crypter security token.
> If not set simply return null should be suffice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
