[
https://issues.apache.org/jira/browse/SHINDIG-1719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221949#comment-13221949
]
[email protected] commented on SHINDIG-1719:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4135/#review5604
-----------------------------------------------------------
Ship it!
LGTM
- Stanton
On 2012-03-02 19:56:52, Henry Saputra wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4135/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-02 19:56:52)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Simplify the SecurityToken.getActiveUrl implementation and definition.
bq.
bq. If not set simply return null should be suffice.
bq.
bq.
bq. This addresses bug SHINDIG-1719.
bq. https://issues.apache.org/jira/browse/SHINDIG-1719
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/java/common/src/test/java/org/apache/shindig/auth/BlobCrypterSecurityTokenTest.java
1295758
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/SecurityToken.java
1295758
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/BasicSecurityToken.java
1295758
bq.
trunk/java/common/src/main/java/org/apache/shindig/auth/BlobCrypterSecurityToken.java
1295758
bq.
bq. Diff: https://reviews.apache.org/r/4135/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit test and run apps in common container
bq.
bq.
bq. Thanks,
bq.
bq. Henry
bq.
bq.
> Remove throwing UnsupportedOperationException with call to
> BlobCrypterSecurityToken.getActiveUrl and BasicSecurityToken.getActiveUrl
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1719
> URL: https://issues.apache.org/jira/browse/SHINDIG-1719
> Project: Shindig
> Issue Type: Bug
> Components: Java
> Affects Versions: 2.5.0
> Reporter: Henry Saputra
> Priority: Minor
> Labels: security_token, shidnig
>
> I dont see any value throwing UnsupportedOperationException in calling
> getActiveUrl method in basic and blob crypter security token.
> If not set simply return null should be suffice.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
