[
https://issues.apache.org/jira/browse/SHINDIG-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223580#comment-13223580
]
[email protected] commented on SHINDIG-1722:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4202/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
As part of the release cycle in our development group, we asked IBM Information
Development to review and edit the log messages in use by shindig. They fixed
some grammatical mistakes, typos in field names, and provided improved wording
in messages based on their guidelines for word usage and clarity of message
content. The attached patch file contains these updates that we would like to
have committed into the shindig base. Additionally, we are pushing the messages
through our various translation centers and will soon be providing a follow-on
patch that contains the NLS versions of the properties files for the base
languages we support.
We also cleaned up the testcases to remove checks on message texts.
This addresses bug SHINDIG-1722.
https://issues.apache.org/jira/browse/SHINDIG-1722
Diffs
-----
trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties
1244227
trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties
1244227
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ErrorTest.java
1244227
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestExceptionTest.java
1244227
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java
1244227
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLoggerTest.java
1244227
Diff: https://reviews.apache.org/r/4202/diff
Testing
-------
passed junit tests.
Thanks,
li
> Improvement to OAuth2Message
> ----------------------------
>
> Key: SHINDIG-1722
> URL: https://issues.apache.org/jira/browse/SHINDIG-1722
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0
> Reporter: li xu
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: oauth2message.patch
>
>
> As part of the release cycle in our development group, we asked IBM
> Information Development to review and edit the OAuth2 error messages in use
> by shindig. They fixed some grammatical mistakes, typos in field names, and
> provided improved wording in messages based on their guidelines for word
> usage and clarity of message content. The attached patch file contains these
> updates that we would like to have committed into the shindig base.
> Additionally, we are pushing the messages through our various translation
> centers and will soon be providing a follow-on patch that contains the NLS
> versions of the properties files for the base languages we support.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
