[
https://issues.apache.org/jira/browse/SHINDIG-1722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13223632#comment-13223632
]
[email protected] commented on SHINDIG-1722:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4202/#review5653
-----------------------------------------------------------
Ship it!
LGTM
- Adam
On 2012-03-06 19:29:51, li xu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4202/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-06 19:29:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As part of the release cycle in our development group, we asked IBM
Information Development to review and edit the log messages in use by shindig.
They fixed some grammatical mistakes, typos in field names, and provided
improved wording in messages based on their guidelines for word usage and
clarity of message content. The attached patch file contains these updates that
we would like to have committed into the shindig base. Additionally, we are
pushing the messages through our various translation centers and will soon be
providing a follow-on patch that contains the NLS versions of the properties
files for the base languages we support.
bq.
bq. We also cleaned up the testcases to remove checks on message texts.
bq.
bq.
bq. This addresses bug SHINDIG-1722.
bq. https://issues.apache.org/jira/browse/SHINDIG-1722
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource.properties
1244227
bq.
trunk/java/gadgets/src/main/resources/org/apache/shindig/gadgets/oauth2/resource_en_US.properties
1244227
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2ErrorTest.java
1244227
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/OAuth2RequestExceptionTest.java
1244227
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/handler/OAuth2HandlerErrorTest.java
1244227
bq.
trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/oauth2/logger/FilteredLoggerTest.java
1244227
bq.
bq. Diff: https://reviews.apache.org/r/4202/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. passed junit tests.
bq.
bq.
bq. Thanks,
bq.
bq. li
bq.
bq.
> Improvement to OAuth2Message
> ----------------------------
>
> Key: SHINDIG-1722
> URL: https://issues.apache.org/jira/browse/SHINDIG-1722
> Project: Shindig
> Issue Type: Improvement
> Components: Java
> Affects Versions: 2.5.0
> Reporter: li xu
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: oauth2message.patch
>
>
> As part of the release cycle in our development group, we asked IBM
> Information Development to review and edit the OAuth2 error messages in use
> by shindig. They fixed some grammatical mistakes, typos in field names, and
> provided improved wording in messages based on their guidelines for word
> usage and clarity of message content. The attached patch file contains these
> updates that we would like to have committed into the shindig base.
> Additionally, we are pushing the messages through our various translation
> centers and will soon be providing a follow-on patch that contains the NLS
> versions of the properties files for the base languages we support.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
