[
https://issues.apache.org/jira/browse/SHINDIG-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225036#comment-13225036
]
[email protected] commented on SHINDIG-1724:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4239/
-----------------------------------------------------------
Review request for shindig, Henry Saputra, li xu, and Dan Dumont.
Summary
-------
if shindig-container feature is included, it overwrites all of the
osapi.container functions created by container feature.
shindig.container/osapi.js should at the very least check that osapi.container
doesn't ready exist before overwriting it to {}.
shindig.container/feature.xml should also be altered to reflect the addition of
osapi.container.listMethods
This addresses bug SHINDIG-1724.
https://issues.apache.org/jira/browse/SHINDIG-1724
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/feature.xml
1298262
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js
1298262
Diff: https://reviews.apache.org/r/4239/diff
Testing
-------
Done
Thanks,
hu
> if shindig-container feature is included, it overwrites all of the
> osapi.container functions created by container feature.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1724
> URL: https://issues.apache.org/jira/browse/SHINDIG-1724
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0
> Reporter: HuJian
>
> if shindig-container feature is included, it overwrites all of the
> osapi.container functions created by container feature.
> shindig.container/osapi.js should at the very least check that
> osapi.container doesn't ready exist before overwriting it to {}.
> shindig.container/feature.xml should also be altered to reflect the addition
> of osapi.container.listMethods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
