[
https://issues.apache.org/jira/browse/SHINDIG-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13225211#comment-13225211
]
[email protected] commented on SHINDIG-1724:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4239/#review5720
-----------------------------------------------------------
shindig-container and container are mutually exclusive features, I really don't
think they were ever intended to be used together, so I'm hesitant to see this
changed.
- Dan
On 2012-03-08 06:31:13, hu jian wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4239/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-08 06:31:13)
bq.
bq.
bq. Review request for shindig, Henry Saputra, li xu, and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. if shindig-container feature is included, it overwrites all of the
osapi.container functions created by container feature.
bq. shindig.container/osapi.js should at the very least check that
osapi.container doesn't ready exist before overwriting it to {}.
bq. shindig.container/feature.xml should also be altered to reflect the
addition of osapi.container.listMethods
bq.
bq.
bq. This addresses bug SHINDIG-1724.
bq. https://issues.apache.org/jira/browse/SHINDIG-1724
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/feature.xml
1298262
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/shindig.container/osapi.js
1298262
bq.
bq. Diff: https://reviews.apache.org/r/4239/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Done
bq.
bq.
bq. Thanks,
bq.
bq. hu
bq.
bq.
> if shindig-container feature is included, it overwrites all of the
> osapi.container functions created by container feature.
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1724
> URL: https://issues.apache.org/jira/browse/SHINDIG-1724
> Project: Shindig
> Issue Type: Bug
> Components: Javascript
> Affects Versions: 2.5.0
> Reporter: HuJian
> Attachments: SHINDIG-1724.patch
>
>
> if shindig-container feature is included, it overwrites all of the
> osapi.container functions created by container feature.
> shindig.container/osapi.js should at the very least check that
> osapi.container doesn't ready exist before overwriting it to {}.
> shindig.container/feature.xml should also be altered to reflect the addition
> of osapi.container.listMethods
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
