[ 
https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230075#comment-13230075
 ] 

[email protected] commented on SHINDIG-1689:
--------------------------------------------------------



bq.  On 2012-03-15 00:21:21, Ryan Baxter wrote:
bq.  >
bq.  
bq.  Ryan Baxter wrote:
bq.      Oops meant to add some context here before I published :)
bq.      
bq.      I am OK with these changes, Henry has asked the obvious changes.  I am 
not really that familiar with some of the implications of these changes, so not 
sure how useful my review is.  Just as a cleanup, I found some trailing 
whitespaces in the changes.
bq.  
bq.  Ate Douma wrote:
bq.      Thanks Ryan. 
bq.      For removal of those whitespaces, would you prefer me to provide a new 
patch or is that something (automatically) can be taken care of by whom would 
commit the patch?

It's not to hard for committers to do it but if you have a sec to create a new 
patch it makes it a little easier on the committer.


- Ryan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review5976
-----------------------------------------------------------


On 2012-02-14 00:03:44, Ate Douma wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/3887/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2012-02-14 00:03:44)
bq.  
bq.  
bq.  Review request for shindig.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  This is a patch for resolving the remaining legal NOTICE and LICENSE 
requirements as reported here: 
http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%[email protected]%3E
bq.  
bq.  The patch also includes fixes needed for Shindig PHP, and updated 
Copyright and license claim for OpenSocial 0.8 usages, see also: 
https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.  
bq.  
bq.  This addresses bug SHINDIG-1689.
bq.      https://issues.apache.org/jira/browse/SHINDIG-1689
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE
 PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE
 PRE-CREATION 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE
 PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE
 PRE-CREATION 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE
 PRE-CREATION 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE
 PRE-CREATION 
bq.    
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE
 PRE-CREATION 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336 
bq.    http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336 
bq.  
bq.  Diff: https://reviews.apache.org/r/3887/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Ate
bq.  
bq.


                
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
>                 Key: SHINDIG-1689
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-1689
>             Project: Shindig
>          Issue Type: Bug
>          Components: Build, Java
>            Reporter: Jesse Ciancetta
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files 
> reported by Ate Douma on the dev mailing list.  Additional detail can be 
> found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%[email protected]%3E

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to