[
https://issues.apache.org/jira/browse/SHINDIG-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13235973#comment-13235973
]
[email protected] commented on SHINDIG-1689:
--------------------------------------------------------
bq. On 2012-03-21 22:09:24, Henry Saputra wrote:
bq. > Actually I just noticed something when trying to commit. What is the
appended-resources directory for? Is it automatically generated by your build?
Seems like aggregation of the NOTICE and LICENSE files
bq.
bq. Ate Douma wrote:
bq. The appended-resources directory is used by the
maven-remote-resources-plugin in combination with the (default configured)
apache-jar-resource-bundle.
bq. That resource bundle provides the standard ASL 2.0 LICENSE and basic
NOTICE file (as velocity template).
bq. The plugin will look for matching resource *fragments* in the
appended-resources folder and if found append them to the base template from
the resource bundle.
bq. Effectively, this largely reduces the amount and size of to be
provided LICENSE and NOTICE file per artifact/module, as only appendable
fragments need to be provided, if needed at all.
bq.
bq. So the appended-resources directory is *not* automatically generated
by my build but needed and used to generate final and complete LICENSE and
NOTICE files.
bq.
bq. Henry Saputra wrote:
bq. Just committed the patch but looks like you just delete the content of
features/NOTICE and other files instead of deleting the files themselves. Any
reason why we need to have those empty files?
Weird. When I applied the patch myself using Eclipse to validate it, it
actually did remove those empty files. Seems to depend on how you apply it or
what tool you use.
It definitely is the intend to remove those empty files, so I suggest to now
manually delete then.
Sorry for the inconvenience.
- Ate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3887/#review6191
-----------------------------------------------------------
On 2012-03-15 13:10:51, Ate Douma wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3887/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-03-15 13:10:51)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. This is a patch for resolving the remaining legal NOTICE and LICENSE
requirements as reported here:
http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%[email protected]%3E
bq.
bq. The patch also includes fixes needed for Shindig PHP, and updated
Copyright and license claim for OpenSocial 0.8 usages, see also:
https://groups.google.com/d/msg/opensocial-and-gadgets-spec/-/YYIFdxVlwD8J
bq.
bq.
bq. This addresses bug SHINDIG-1689.
bq. https://issues.apache.org/jira/browse/SHINDIG-1689
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/extras/NOTICE 1243336
bq.
http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/appended-resources/META-INF/NOTICE
PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/NOTICE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1243336
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/LICENSE
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/appended-resources/META-INF/NOTICE
PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/java/NOTICE 1243336
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/LICENSE
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/main/appended-resources/META-INF/NOTICE
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/LICENSE
PRE-CREATION
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/uber/src/main/appended-resources/META-INF/NOTICE
PRE-CREATION
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/LICENSE 1243336
bq. http://svn.apache.org/repos/asf/shindig/trunk/php/NOTICE 1243336
bq.
bq. Diff: https://reviews.apache.org/r/3887/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Ate
bq.
bq.
> Cleanup NOTICE and LICENSE files
> --------------------------------
>
> Key: SHINDIG-1689
> URL: https://issues.apache.org/jira/browse/SHINDIG-1689
> Project: Shindig
> Issue Type: Bug
> Components: Build, Java
> Reporter: Jesse Ciancetta
> Attachments: SHINDIG-1689.patch
>
>
> Issue to track the cleanup of issues found in NOTICE and LICENSE files
> reported by Ate Douma on the dev mailing list. Additional detail can be
> found in this email thread:
> http://mail-archives.apache.org/mod_mbox/shindig-dev/201201.mbox/%[email protected]%3E
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
