[
https://issues.apache.org/jira/browse/SHINDIG-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251475#comment-13251475
] [email protected] commented on SHINDIG-1721: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/#review6838 ----------------------------------------------------------- Looks like some things were missed when pulling the results feature out. See inline comments. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15229> Why is this here? I thought this was part of the new results feature? http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15230> Same as setReturnValue above http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15232> I don't see this being used. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15233> I don't see this being used either. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15231> Same as setReturnValue above. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml <https://reviews.apache.org/r/4693/#comment15234> This isn't being used. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js <https://reviews.apache.org/r/4693/#comment15228> Whitespace - Stanton On 2012-04-10 20:35:22, Dan Dumont wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4693/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-10 20:35:22) bq. bq. bq. Review request for shindig. bq. bq. bq. Summary bq. ------- bq. bq. Broke features apart into smaller features. bq. bq. Updated mixin function in common container to allow you to mix several of the same namespace in. bq. bq. bq. This addresses bug SHINDIG-1721. bq. https://issues.apache.org/jira/browse/SHINDIG-1721 bq. bq. bq. Diffs bq. ----- bq. bq. http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965 bq. http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965 bq. bq. Diff: https://reviews.apache.org/r/4693/diff bq. bq. bq. Testing bq. ------- bq. bq. All existing tests pass bq. bq. bq. Thanks, bq. bq. Dan bq. bq. > Separate out the different open* APIs into their own features so they can > easily be enabled/disabled > ---------------------------------------------------------------------------------------------------- > > Key: SHINDIG-1721 > URL: https://issues.apache.org/jira/browse/SHINDIG-1721 > Project: Shindig > Issue Type: Bug > Affects Versions: 2.5.0-beta1 > Reporter: Ryan Baxter > > The gadgets.views.open* APIs are all under one feature. Since they are all > really providing different sets of functionality it would be nice if we could > separate them out into their own features. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
