[
https://issues.apache.org/jira/browse/SHINDIG-1721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251520#comment-13251520
] [email protected] commented on SHINDIG-1721: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4693/ ----------------------------------------------------------- (Updated 2012-04-11 12:51:08.982077) Review request for shindig. Changes ------- Removed leftover feature.xml declarations in open-views.common Summary ------- Broke features apart into smaller features. Updated mixin function in common container to allow you to mix several of the same namespace in. This addresses bug SHINDIG-1721. https://issues.apache.org/jira/browse/SHINDIG-1721 Diffs (updated) ----- http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/features.txt 1311965 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/pom.xml 1311965 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container/container.js 1311965 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.common/open-views-common-gadget.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-gadget.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.gadget/open-views-gadget-gadget.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.results/open-views-results-gadget.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/feature.xml PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-container.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views.url/open-views-url-gadget.js PRE-CREATION http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/feature.xml 1311965 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements-container.js 1311965 http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/open-views/viewenhancements.js 1311965 Diff: https://reviews.apache.org/r/4693/diff Testing ------- All existing tests pass Thanks, Dan > Separate out the different open* APIs into their own features so they can > easily be enabled/disabled > ---------------------------------------------------------------------------------------------------- > > Key: SHINDIG-1721 > URL: https://issues.apache.org/jira/browse/SHINDIG-1721 > Project: Shindig > Issue Type: Bug > Affects Versions: 2.5.0-beta1 > Reporter: Ryan Baxter > > The gadgets.views.open* APIs are all under one feature. Since they are all > really providing different sets of functionality it would be nice if we could > separate them out into their own features. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
