[
https://issues.apache.org/jira/browse/SHINDIG-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251705#comment-13251705
]
[email protected] commented on SHINDIG-1747:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/
-----------------------------------------------------------
Review request for shindig, Stanton Sievers and Dan Dumont.
Summary
-------
AbstractLockedDomainService has both a protected enabled variable as well as a
public isEnabled method. Both of which can be used to determine whether locked
domains is enabled. However the methods in AbstractLockedDomainService and
HashLockedDomainService all use the protected enabled variable so if someone
who extends AbstractLockedDomainService or HashLockedDomainService and
overrides isEnabled it won't actually be honored or used by any of the methods.
This addresses bug SHINDIG-1747.
https://issues.apache.org/jira/browse/SHINDIG-1747
Diffs
-----
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java
1324741
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
1324741
Diff: https://reviews.apache.org/r/4698/diff
Testing
-------
Unit tests passed
Thanks,
Ryan
> AbstractLockedDomainService has a protected enabled variable as well as a
> public isEnabled method
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1747
> URL: https://issues.apache.org/jira/browse/SHINDIG-1747
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Priority: Minor
> Attachments: issue-1747.patch
>
>
> AbstractLockedDomainService has both a protected enabled variable as well as
> a public isEnabled method. Both of which can be used to determine whether
> locked domains is enabled. However the methods in
> AbstractLockedDomainService and HashLockedDomainService all use the protected
> enabled variable so if someone who extends AbstractLockedDomainService or
> HashLockedDomainService and overrides isEnabled it won't actually be honored
> or used by any of the methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
