[
https://issues.apache.org/jira/browse/SHINDIG-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251780#comment-13251780
]
[email protected] commented on SHINDIG-1747:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4698/#review6858
-----------------------------------------------------------
Ship it!
+1
- Stanton
On 2012-04-11 16:22:00, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4698/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-11 16:22:00)
bq.
bq.
bq. Review request for shindig, Stanton Sievers and Dan Dumont.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. AbstractLockedDomainService has both a protected enabled variable as well
as a public isEnabled method. Both of which can be used to determine whether
locked domains is enabled. However the methods in AbstractLockedDomainService
and HashLockedDomainService all use the protected enabled variable so if
someone who extends AbstractLockedDomainService or HashLockedDomainService and
overrides isEnabled it won't actually be honored or used by any of the methods.
bq.
bq.
bq. This addresses bug SHINDIG-1747.
bq. https://issues.apache.org/jira/browse/SHINDIG-1747
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/AbstractLockedDomainService.java
1324741
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/HashLockedDomainService.java
1324741
bq.
bq. Diff: https://reviews.apache.org/r/4698/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Unit tests passed
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> AbstractLockedDomainService has a protected enabled variable as well as a
> public isEnabled method
> -------------------------------------------------------------------------------------------------
>
> Key: SHINDIG-1747
> URL: https://issues.apache.org/jira/browse/SHINDIG-1747
> Project: Shindig
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
> Assignee: Ryan Baxter
> Priority: Minor
> Fix For: 2.5.0
>
> Attachments: issue-1747.patch
>
>
> AbstractLockedDomainService has both a protected enabled variable as well as
> a public isEnabled method. Both of which can be used to determine whether
> locked domains is enabled. However the methods in
> AbstractLockedDomainService and HashLockedDomainService all use the protected
> enabled variable so if someone who extends AbstractLockedDomainService or
> HashLockedDomainService and overrides isEnabled it won't actually be honored
> or used by any of the methods.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
