[
https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13269997#comment-13269997
] [email protected] commented on SHINDIG-1769: -------------------------------------------------------- ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/5055/ ----------------------------------------------------------- Review request for shindig. Summary ------- Section 2.1.1.1 of the Social Server API spec indicates that when a GET request is made to the person API with a user id of -1 we should return the anonymous user. Today we are throwing an exception because we look for a person with -1 as their id in the canonicaldb and we can't find it. http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 This addresses bug SHINDIG-1769. https://issues.apache.org/jira/browse/SHINDIG-1769 Diffs ----- http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java 1335204 http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java 1335204 Diff: https://reviews.apache.org/r/5055/diff Testing ------- Thanks, Ryan > Person API should handle "-1" as a user id > ------------------------------------------ > > Key: SHINDIG-1769 > URL: https://issues.apache.org/jira/browse/SHINDIG-1769 > Project: Shindig > Issue Type: Improvement > Affects Versions: 2.5.0 > Reporter: Ryan Baxter > > Section 2.1.1.1 of the Social Server API spec indicates that when a GET > request is made to the person API with a user id of -1 we should return the > anonymous user. Today we are throwing an exception because we look for a > person with -1 as their id in the canonicaldb and we can't find it. > http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
