[
https://issues.apache.org/jira/browse/SHINDIG-1769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13270036#comment-13270036
]
[email protected] commented on SHINDIG-1769:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5055/#review7656
-----------------------------------------------------------
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
<https://reviews.apache.org/r/5055/#comment16870>
With this here is seemed to override whatever was set in the
shindig.properties file. I would also like to only set it once if possible so
it is less cryptic.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
<https://reviews.apache.org/r/5055/#comment16871>
Yup missed the "and" in that statement I can do that.
- Ryan
On 2012-05-07 20:59:08, Ryan Baxter wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5055/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-07 20:59:08)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Section 2.1.1.1 of the Social Server API spec indicates that when a GET
request is made to the person API with a user id of -1 we should return the
anonymous user. Today we are throwing an exception because we look for a person
with -1 as their id in the canonicaldb and we can't find it.
bq.
bq.
http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
bq.
bq.
bq. This addresses bug SHINDIG-1769.
bq. https://issues.apache.org/jira/browse/SHINDIG-1769
bq.
bq.
bq. Diffs
bq. -----
bq.
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/conf/shindig.properties
1335204
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/common/src/main/java/org/apache/shindig/auth/AnonymousSecurityToken.java
1335204
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/core/config/SocialApiGuiceModule.java
1335204
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/main/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialService.java
1335204
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/opensocial/service/PersonHandlerTest.java
1335204
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java
1335204
bq.
bq. Diff: https://reviews.apache.org/r/5055/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Updated unit tests
bq.
bq.
bq. Thanks,
bq.
bq. Ryan
bq.
bq.
> Person API should handle "-1" as a user id
> ------------------------------------------
>
> Key: SHINDIG-1769
> URL: https://issues.apache.org/jira/browse/SHINDIG-1769
> Project: Shindig
> Issue Type: Improvement
> Affects Versions: 2.5.0
> Reporter: Ryan Baxter
>
> Section 2.1.1.1 of the Social Server API spec indicates that when a GET
> request is made to the person API with a user id of -1 we should return the
> anonymous user. Today we are throwing an exception because we look for a
> person with -1 as their id in the canonicaldb and we can't find it.
> http://opensocial-resources.googlecode.com/svn/spec/trunk/Social-API-Server.xml#rfc.section.2.1.1.1
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
