[
https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13274726#comment-13274726
]
[email protected] commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7844
-----------------------------------------------------------
Initial pass looks OK for the most part. A sample gadget that makes use of
these new APIs would be very helpful in demonstrating the concept.
http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
<https://reviews.apache.org/r/5112/#comment17177>
It looks like there is an extra "%" here between url and authz.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5112/#comment17178>
Use the "st" var here since you defined it above.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
<https://reviews.apache.org/r/5112/#comment17179>
Use the "st" var here since you defined it above.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17173>
It appears that request could be null here.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17174>
small nit on trailing whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17175>
small nit on whitespace
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
<https://reviews.apache.org/r/5112/#comment17176>
The formatting seems weird here. Can you make sure you are using 2 spaces
instead of tabs and 4 spaces for line continuations per the Shindig style
guidelines?
- Stanton
On 2012-05-14 15:53:08, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-14 15:53:08)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian
Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to
specify the auth scheme used, also check for the AUTHORIZATION and
OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional
HttpServletRequest to ProxyHandler to build the HttpRequest object, in the
ProxyHandler additional information as security token, auth type, oauth service
and gadget will be used to construct a HttpRequest to pass to the
DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1338171
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1338232
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
1338123
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
1335359
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml
1335359
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are
> desired to be accessed via content proxy instead of makeRequest calls, for
> example, images in user's album. User should be able to specify OAuth
> parameter in getProxyUrl call and get a proxy url to access the protected
> resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
