[
https://issues.apache.org/jira/browse/SHINDIG-1773?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13277772#comment-13277772
]
[email protected] commented on SHINDIG-1773:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/5112/#review7956
-----------------------------------------------------------
Instead of passing the request along into ProxyHandler, I think the normal flow
is to ensure the information you need is in the ProxyUri that gets passed
along. For instance,
org.apache.shindig.gadgets.uri.ProxyUriBase.setFromUri(Uri) sets things like
rewrite MIME, the gadget, and the container for the proxy uri today. The
intent would be that ProxyServlet.processRequest() creates the ProxyUri via the
ProxyUriManager and then that Uri would be used in ProxyHandler to do the type
of checking you want, instead of having to pass the request along.
Also see org.apache.shindig.gadgets.uri.UriCommon.Param for the other params
that are defined for Uris.
- Stanton
On 2012-05-15 12:04:39, Xiao Feng Yu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/5112/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-05-15 12:04:39)
bq.
bq.
bq. Review request for Ryan Baxter, Dan Dumont, Stanton Sievers, and Brian
Lillie.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Couple of changes are included in this patch.
bq. 1) On the client side, the getProxyUrl is updated to add auth parameter to
specify the auth scheme used, also check for the AUTHORIZATION and
OAUTH_SERVICE setting and add them in proxy url.
bq. 2) On the server side, proxy servlet will pass additional
HttpServletRequest to ProxyHandler to build the HttpRequest object, in the
ProxyHandler additional information as security token, auth type, oauth service
and gadget will be used to construct a HttpRequest to pass to the
DefaultRequestPipeline for handling.
bq.
bq.
bq. This addresses bug Shindig-1773.
bq. https://issues.apache.org/jira/browse/Shindig-1773
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. http://svn.apache.org/repos/asf/shindig/trunk/config/container.js
1338565
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/core.io/io.js
1338565
bq.
http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/core.io/iotest.js
1338595
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyHandler.java
1338565
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ProxyServlet.java
1338565
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ProxyServletTest.java
1338565
bq.
http://svn.apache.org/repos/asf/shindig/trunk/java/server-resources/src/main/webapp/WEB-INF/web.xml
1338565
bq.
bq. Diff: https://reviews.apache.org/r/5112/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Xiao Feng
bq.
bq.
> Content proxy needs to support proxy for OAuth protected resources
> ------------------------------------------------------------------
>
> Key: SHINDIG-1773
> URL: https://issues.apache.org/jira/browse/SHINDIG-1773
> Project: Shindig
> Issue Type: New Feature
> Components: Java
> Affects Versions: 2.5.0, 3.0.0
> Reporter: Xiao Feng Yu
> Fix For: 2.5.0, 3.0.0
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There are many cases that some resource are protected by OAuth and they are
> desired to be accessed via content proxy instead of makeRequest calls, for
> example, images in user's album. User should be able to specify OAuth
> parameter in getProxyUrl call and get a proxy url to access the protected
> resources.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
