[
https://issues.apache.org/jira/browse/SHIRO-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17620418#comment-17620418
]
Tamas Cservenak commented on SHIRO-892:
---------------------------------------
My assumption is that JIT Guice binding kicks in (in case of test you pointed
at, or the other test I was looking at, the WebGuiceEnvironmentTest), but in a
moment you require explicit bindings, you see same error I got: the new config
class is not bound.
Now, as you may know, we use SISU and not pure Guice, hence the mixed use of
javax.inject and com.google.inject annotation on WebGuiceEnvironment class may
just complicate things, but I am not aware that Eclipse SISU would insist on
explicit bindings... so unsure still.
Explicit binding as your gist would probably be the best still...
> No Guice binding for newly introduced ShiroFilterConfiguration
> --------------------------------------------------------------
>
> Key: SHIRO-892
> URL: https://issues.apache.org/jira/browse/SHIRO-892
> Project: Shiro
> Issue Type: Bug
> Components: Integration: Guice
> Affects Versions: 1.10.0
> Reporter: Tamas Cservenak
> Assignee: Jared Bunting
> Priority: Major
>
> When using Shiro 1.10.0 using Guice, the object graph is incomplete (no
> binding for ShiroFilterConfiguration). Release notes did not mention that
> user must provide it either.
> Personally, I'd prefer to have Shiro provide one "out of the box" if
> possible, as otherwise this may count as "breaking change"?
> Cause is this commit:
> [https://github.com/apache/shiro/commit/28e10e0ca1cdcd2cede86802fde8464b29265fc8]
> Reproducer: try to "boot off" Shiro as an "Guice app would" (using Guice
> integration, ie. prep a sample app using 1.9.1 then migrate it to 1.10.0 ->
> incomplete graph)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
