[
https://issues.apache.org/jira/browse/SHIRO-892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17624933#comment-17624933
]
Benjamin Marwell commented on SHIRO-892:
----------------------------------------
We can add this to the test:
{code:java}
binder().requireExplicitBindings();
{code}
BUT. It would need more than that for the tests (this is
{{{}ShiroWebModuleTest.basicInstantiation(){}}}.
{code:java}
1) Explicit bindings are required and
org.apache.shiro.web.config.ShiroFilterConfiguration is not explicitly bound.
while locating org.apache.shiro.web.config.ShiroFilterConfiguration
for the 3rd parameter of
org.apache.shiro.guice.web.GuiceShiroFilter.<init>(GuiceShiroFilter.java:35)
at
org.apache.shiro.guice.web.ShiroWebModule.configureShiro(ShiroWebModule.java:139)
2) Explicit bindings are required and
org.apache.shiro.web.session.mgt.ServletContainerSessionManager would be bound
in a parent injector.
Please add an explicit binding for it, either in the child or the parent.
at org.apache.shiro.guice.ShiroModule.configure(ShiroModule.java:73)
3) Explicit bindings are required and
org.apache.shiro.event.support.DefaultEventBus would be bound in a parent
injector.
Please add an explicit binding for it, either in the child or the parent.
at org.apache.shiro.guice.ShiroModule.configure(ShiroModule.java:76)
4) Explicit bindings are required and
org.apache.shiro.guice.web.WebGuiceEnvironment would be bound in a parent
injector.
Please add an explicit binding for it, either in the child or the parent.
at
org.apache.shiro.guice.web.ShiroWebModule.configureShiro(ShiroWebModule.java:138)
{code}
> No Guice binding for newly introduced ShiroFilterConfiguration
> --------------------------------------------------------------
>
> Key: SHIRO-892
> URL: https://issues.apache.org/jira/browse/SHIRO-892
> Project: Shiro
> Issue Type: Bug
> Components: Integration: Guice
> Affects Versions: 1.10.0
> Reporter: Tamas Cservenak
> Assignee: Jared Bunting
> Priority: Major
>
> When using Shiro 1.10.0 using Guice, the object graph is incomplete (no
> binding for ShiroFilterConfiguration). Release notes did not mention that
> user must provide it either.
> Personally, I'd prefer to have Shiro provide one "out of the box" if
> possible, as otherwise this may count as "breaking change"?
> Cause is this commit:
> [https://github.com/apache/shiro/commit/28e10e0ca1cdcd2cede86802fde8464b29265fc8]
> Reproducer: try to "boot off" Shiro as an "Guice app would" (using Guice
> integration, ie. prep a sample app using 1.9.1 then migrate it to 1.10.0 ->
> incomplete graph)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
