desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792401084
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java:
##########
@@ -88,20 +106,58 @@ final class ClientFileSystem extends FileSystem {
this.provider = provider;
this.client = client;
this.accessKey = null;
+ this.host = null;
+ this.port = null;
this.separator = DEFAULT_SEPARATOR;
duplicatedSeparator = DEFAULT_SEPARATOR + DEFAULT_SEPARATOR;
}
+ /**
+ * Creates a file system with default hostname and default separator.
+ */
+ ClientFileSystem(final FileService provider, final S3Client client, String
accessKey) {
+ this.provider = provider;
+ this.client = client;
+ this.accessKey = accessKey;
+ this.host = null;
+ this.port = null;
+ this.separator = DEFAULT_SEPARATOR;
+ duplicatedSeparator = DEFAULT_SEPARATOR + DEFAULT_SEPARATOR;
+ }
+
+ /**
+ * Creates a file system with default credential and default separator.
+ */
+ ClientFileSystem(final FileService provider, String accessKey, String
host, Integer port, boolean isHttps) {
Review Comment:
I think that we can omit this constructor, as it duplicate the next
constructor below. Caller only need to add some more `null` argument value.
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java:
##########
@@ -88,20 +106,58 @@ final class ClientFileSystem extends FileSystem {
this.provider = provider;
this.client = client;
this.accessKey = null;
+ this.host = null;
+ this.port = null;
this.separator = DEFAULT_SEPARATOR;
duplicatedSeparator = DEFAULT_SEPARATOR + DEFAULT_SEPARATOR;
}
+ /**
+ * Creates a file system with default hostname and default separator.
+ */
+ ClientFileSystem(final FileService provider, final S3Client client, String
accessKey) {
+ this.provider = provider;
+ this.client = client;
+ this.accessKey = accessKey;
+ this.host = null;
+ this.port = null;
+ this.separator = DEFAULT_SEPARATOR;
+ duplicatedSeparator = DEFAULT_SEPARATOR + DEFAULT_SEPARATOR;
+ }
+
+ /**
+ * Creates a file system with default credential and default separator.
+ */
+ ClientFileSystem(final FileService provider, String accessKey, String
host, Integer port, boolean isHttps) {
Review Comment:
I think that we can omit this constructor, as it duplicates the next
constructor below. Caller only need to add some more `null` argument value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
