desruisseaux commented on code in PR #40:
URL: https://github.com/apache/sis/pull/40#discussion_r2792408534
##########
endorsed/src/org.apache.sis.cloud.aws/main/org/apache/sis/cloud/aws/s3/ClientFileSystem.java:
##########
@@ -115,6 +171,15 @@ final class ClientFileSystem extends FileSystem {
if (region != null) {
builder = builder.region(region);
}
+ this.host = host;
+ this.port = port;
+ this.isHttps = (isHttps != null ? isHttps : true);
+ if (host != null) {
+ String hostname = (port != null ? host+":"+port : host);
Review Comment:
Space between `+`, and `":"` can be replaced by `':'` (adding a single
character is slightly more efficient than adding a string).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
