magibney commented on a change in pull request #2:
URL: https://github.com/apache/solr/pull/2#discussion_r593348695
##########
File path: solr/core/src/java/org/apache/solr/search/facet/SweepCountAware.java
##########
@@ -165,7 +165,10 @@ public final void incrementCount(int segOrd, int inc, int
maxIdx) {
*/
public void register(CountSlotAcc[] countAccs, LongValues toGlobal, int
maxSegOrd) {
int segOrd = maxSegOrd;
- final int maxIdx = countAccs.length - 1;
+ // NOTE: the `countAccs` array may be oversized (e.g., in the event that
one or more of the domains supplies a <code>null</code>
Review comment:
:-) hehe, on a latent bug that I introduced. Hopefully caught it while
still entirely latent!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
