magibney commented on pull request #2: URL: https://github.com/apache/solr/pull/2#issuecomment-800752941
6dbc647 addresses the potential read race condition on checking the top-level non-volatile `cachedOrdIdxMap`; but iiuc you're also concerned about the possibility of re-ordering writes to the _elements_ of the array to _after_ writing the top-level array to the shared variable? Uwe's answer on the mailing list implicitly seems (?) to suggest that might not be a concern; and I was unable (in a trivial test application) to generate errors on that type of condition; but I still think the concern is well-founded. In any event 6dbc647 should be an improvement ... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
