[ 
https://issues.apache.org/jira/browse/SOLR-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315872#comment-17315872
 ] 

Houston Putman commented on SOLR-15321:
---------------------------------------

Ahh, I missed that part in tianon's repsonse. The fact that the docker team 
requires the ability to modify the Dockerfile in review makes this plan not as 
tenable. Since we can't change the git tag after the vote succeeds.

My idea was that there wouldn't be a need for a separate repo/commit if we 
could just use the Solr release tag in the Solr repo. You can specificy a 
[different git 
commit|https://github.com/docker-library/official-images/blob/master/library/solr#L11]
 for every version in the official images repo. So there's no need to actually 
store multiple versions of the Dockerfile in the same branch, each tag would 
just have the git commit from that Solr release. The only reason that was done 
in docker-solr was because all versions were re-generated anytime the scripts 
or Dockerfile changed. I'm not exactly sure why this is sketchy, but I'm fine 
keeping docker-solr, although we should probably move it to apache instead of 
keeping it in it's own github org.

I completely agree that it should be voted on. But the releaseWizard could 
setup the file to be committed *after* the vote succeeds (we have to setup 
something similar in the solr-operator release wizard). However, the 
Dockerfile.official that we generate wouldn't really be able to be tested. It 
could only be verified by looking through it, since the artifacts aren't 
uploaded to the mirrors yet.

> Flesh out process for managing/storing "official" Dockerfiles used by 
> docker-library
> ------------------------------------------------------------------------------------
>
>                 Key: SOLR-15321
>                 URL: https://issues.apache.org/jira/browse/SOLR-15321
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Chris M. Hostetter
>            Priority: Major
>
> Assuming we (the Apache Solr TLP) do want to be the maintainer of "official" 
> {{_/solr}} docker images moving forward, we need to flesh out how/where 
> exactly we plan on storing/managing/maintaining the Dockerfiles that should 
> be pointed to by the docker-library manifest file for solr...
> [https://github.com/docker-library/official-images/blob/master/library/solr]
> ie:
>  * what replaces [https://github.com/docker-solr/docker-solr.git]
>  * what process do we use to update/manage this?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to