[
https://issues.apache.org/jira/browse/SOLR-15321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17315880#comment-17315880
]
Chris M. Hostetter commented on SOLR-15321:
-------------------------------------------
{quote}.. I'm not exactly sure why this is sketchy, ...
{quote}
My sketchy comment was about the idea that – IIUC what you were suggesting, and
it seems like i was – the Dockerfile for 9.1.1would get committed to
{{branch_9_1}} as soon as the 9.1.1 release was official, but then it would get
deleted right away _before_ changing the gradle {{baseVersion}} to be 9.1.2,
and the *ONLY* way to find it, would be to know what git SHA to look for in
history.
yes, that SHA would be in the docker-library/official-images/library/solr
manifest file – which is all that would matter for the docker-library folks,
but seemed sketchy to me from a "As an apache project, this is where we keep
our Dockerfiles"
{quote}I completely agree that it should be voted on. But the releaseWizard
could setup the file to be committed *after* the vote succeeds...
{quote}
Oh yeah, 100% agree: for every RC the release process/wizard should generate
the Dockerfile.official with the GPG & SHA256 values all filled in, and once
the vote passes the release process/wizard can/should commit that file and
subit the PR to docker-library/official-images to update the library/solr
manifest file.
I just feel like the existing docker-solr process seems a lot cleaner then
files that only exist at specific moments in the git log and are then deleted.
{quote}... However, the Dockerfile.official that we generate wouldn't really be
able to be tested. It could only be verified by looking through it, since the
artifacts aren't uploaded to the mirrors yet.
{quote}
why wouldn't it be testable as part of the release smoker? The way
{{SOLR_DOWNLOAD_URL}} is currently parameterized in the existing (8x)
Dockerfiles already makes it possible to "smoke test" an RC with a Dockerfile –
it just skips GPG verification. if we include a build {{ARG}} for the GPG
signature (with a default value of
{{https://archive.apache.org/.../solr-X.Y.Z.tgz.asc}}) then even that can be
tested.
> Flesh out process for managing/storing "official" Dockerfiles used by
> docker-library
> ------------------------------------------------------------------------------------
>
> Key: SOLR-15321
> URL: https://issues.apache.org/jira/browse/SOLR-15321
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Priority: Major
>
> Assuming we (the Apache Solr TLP) do want to be the maintainer of "official"
> {{_/solr}} docker images moving forward, we need to flesh out how/where
> exactly we plan on storing/managing/maintaining the Dockerfiles that should
> be pointed to by the docker-library manifest file for solr...
> [https://github.com/docker-library/official-images/blob/master/library/solr]
> ie:
> * what replaces [https://github.com/docker-solr/docker-solr.git]
> * what process do we use to update/manage this?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
