[
https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325351#comment-17325351
]
Chris M. Hostetter commented on SOLR-15335:
-------------------------------------------
{quote}Just to be clear, have you changed any of the logic in
Dockerfile.body.template, or is that the same as it was previously?
{quote}
it should be exactly the same, except for the comments at the top of the file,
moving the COPY line out (now in the header) and tweaking the "delete stuff we
don't need" line to rm {{Dockerfile*}} instead of just {{Dockerfile}} now that
we name it {{Dockerfile.local}} inside the tgz ("git diff" doesn't make it easy
to see after applying the patch, but in the patch itself it's easy to see how
exactly the body template differs fro mthe old Dockerfile
{quote}I think we can minimize the number of layers in the Dockerfile. There
are a lot of RUNs that can be consolidated
{quote}
most certainly – but for right now I was trying to minimize changes to *JUST*
deal with adding the templating and proving that both versions of the
dockerfile could be "tested"
{quote}What's the reasoning behind changing dockerContext from Sync to Copy?
{quote}
this could (and arguably "should") actually be "fixed" in it's own commit prior
to this jira – Sync deletes anything in the dest dir that isn't in the source
dir, and while working on this i noticed some of the new tasks kept re-doing
work (or failing) because that the dockerContext 'sync' was removing stuff from
the build dir that shouldn't have (that sync should have been replaced with a
copy as soon as we switched from creating a context/ dir – which might have had
"old" scripts that needed deleted – to replacing a context.tgz)
> templated (header + body) approach for building Dockerfile.local +
> Dockerfile.official w/common guts
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-15335
> URL: https://issues.apache.org/jira/browse/SOLR-15335
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch,
> SOLR-15335.patch
>
>
> Goals:
> * "generate" a Dockerfile.official at release time that will satisfy the
> process/tooling of docker-library for 'official' docker images
> ** use a templated approach to fill in things like version, sha512, and GPG
> fingerprint
> * ensure that the generated Dockerfile.official and the Dockerfile.local
> included in solr.tgz are identical in terms of the "operational" aspects of a
> Solr docker image (ie: what the disk layout looks like, and how it runs)
> ** they should only differ in how they get the contents of a solr.tgz into
> the docker image (and how much they trust it before unpacking it)
> * minimize the amount of overhead needed to make changes that exist in in
> both dockerfiles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
