[
https://issues.apache.org/jira/browse/SOLR-15335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17339178#comment-17339178
]
Houston Putman commented on SOLR-15335:
---------------------------------------
Ok, so I've run the tests, and looked at the dockerfiles and the code looks
good. I do have a few issues/suggestions:
* I have to disable buildkit in docker to run this task, because buildkit does
not support custom networks unfortunately. This isn't necessarily a blocker,
since this test probably isn't going to be used _that_ often, but it's
something to think about in the future. We might want to setup a Jenkins
nightly test for this, and not have the ability to turn off buildkit for the
docker engine there.
** There might be a way to hookup the fakeServer IP instead of creating a
custom network. Will do some research here
* If you are interested in comments on the contents of the Dockerfile, I'll
list them here. If you mainly want to get the build setup and optimize later,
that's fine.
** We can consolidate a lot of these statements, particularly the run
statements.
** We should change the maintainer/github repo labels to reflect the Solr TLP
** In the Official template, as your comment points out, there is room to
remove a fair amount of that stuff if we are suggesting that users use the
"local" option when building their own images.
Once again I'm not a gradle expert, so can't comment that much on the complex
code you have going on there. But I'll try to dig in more
> templated (header + body) approach for building Dockerfile.local +
> Dockerfile.official w/common guts
> ----------------------------------------------------------------------------------------------------
>
> Key: SOLR-15335
> URL: https://issues.apache.org/jira/browse/SOLR-15335
> Project: Solr
> Issue Type: Sub-task
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Attachments: SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch,
> SOLR-15335.patch, SOLR-15335.patch, SOLR-15335.patch
>
>
> Goals:
> * "generate" a Dockerfile.official at release time that will satisfy the
> process/tooling of docker-library for 'official' docker images
> ** use a templated approach to fill in things like version, sha512, and GPG
> fingerprint
> * ensure that the generated Dockerfile.official and the Dockerfile.local
> included in solr.tgz are identical in terms of the "operational" aspects of a
> Solr docker image (ie: what the disk layout looks like, and how it runs)
> ** they should only differ in how they get the contents of a solr.tgz into
> the docker image (and how much they trust it before unpacking it)
> * minimize the amount of overhead needed to make changes that exist in in
> both dockerfiles
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
