[
https://issues.apache.org/jira/browse/SOLR-15361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17331072#comment-17331072
]
Chris M. Hostetter commented on SOLR-15361:
-------------------------------------------
{quote}this should have the value of the property, not null. You don't even
need the input for this task at all since you probably want to run it always.
{quote}
Hmm... ok, I guess i'm missundertsanindg the javadocs of TaskInputs.property
then ... i thought the point of the 'value' param was to set a default that
would be cached (for he 'up to date' check) in place of the property value in
the event the property wasn't set. but yeah, we probably don't need the input
at all.
{quote}This should be replaced with a doFirst block and just a check on whether
the valkue of the property was provided or not (and is not blank). If the task
runs, you'll know it's part of the graph - no need to check it. So:
{quote}
Ok ... i can change that, but FWIW the reason i explicitly used
gradle.taskGraph.whenReady instead of a doFirst was so that if
failUnlessGpgKeyProperty was in the taskGraph the build would fail ASAP after
configuration – before any unrelated tasks in the graph started executing.
If we put it in a doFirst, then {{./gradlew signDist}} will happily start
running other distribution dependencies (like compileJava}} before realizing
that failUnlessGpgKeyProperty is causing hte whole buidl to fail.
> update gradle build to support gpg signing of tgz/zip distributions
> -------------------------------------------------------------------
>
> Key: SOLR-15361
> URL: https://issues.apache.org/jira/browse/SOLR-15361
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Chris M. Hostetter
> Assignee: Chris M. Hostetter
> Priority: Major
> Fix For: main (9.0)
>
> Attachments: SOLR-15361.patch, SOLR-15361.patch, SOLR-15361.patch
>
>
> the gradle build does not currently have any support for gpg signing the
> distributions we produce.
> this is neccessary for releases, and for being able to "smoke test" our
> Dockerfiles prior to release (by creating mock download servers to confirm
> {{docker build}} can correctly fetch the {{tgz}} & {{tgz.asc}} files we point
> it at)
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
