[
https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349102#comment-17349102
]
Andras Salamon commented on SOLR-15421:
---------------------------------------
Wow, lots of responses. Thanks for everyone.
[~houstonputman] pointed out an NPE problem, I'll definitely fix that.
[~nazerke] Yes, my pull request has a very similar code line.
[~dsmiley] I'm looking for the root cause of course, and trying to prevent
that, but it's always possible to accidentally get an empty directory (I know
that it's not good but sometimes it is just necessary to manually edit
zookeeper nodes after some failure, it is always possible to get this result).
Creating a second method is not nice that's true, I was not brave enough to
modify the existing one, but I'll do that and check the unit tests.
> ConfigSetService.checkConfigExists accepts empty configs
> --------------------------------------------------------
>
> Key: SOLR-15421
> URL: https://issues.apache.org/jira/browse/SOLR-15421
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Andras Salamon
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Both {{FileSystemConfigSetService}} and {{ZkConfigSetService}} only checks
> the existence of the directory only, if we accidentally create an empty
> config directory this method returns true, but when we try to use the configs
> to create a collection we got an error message like this:
> {noformat}
> Can't find resource 'solrconfig.xml' in classpath or '/configs/config_name',
> cwd=/path/to/lib/solr/server {noformat}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
