[ 
https://issues.apache.org/jira/browse/SOLR-15421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17349324#comment-17349324
 ] 

Andras Salamon commented on SOLR-15421:
---------------------------------------

I have tried to add the logic to the existing {{checkConfigExists}} method, but 
got lots of unit test errors.

Seems to me that we have the following code here 
([https://github.com/apache/solr/blob/main/solr/core/src/java/org/apache/solr/cloud/ConfigSetCmds.java#L187-L189]
 ):
{noformat}
if (!coreContainer.getConfigSetService().checkConfigExists(configSetName)) {
  throw new SolrException(SolrException.ErrorCode.BAD_REQUEST, "ConfigSet does 
not exist to delete: " + configSetName);
} {noformat}

so with these change it's not possible to remove malformed configsets.

 

> ConfigSetService.checkConfigExists accepts empty configs
> --------------------------------------------------------
>
>                 Key: SOLR-15421
>                 URL: https://issues.apache.org/jira/browse/SOLR-15421
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Andras Salamon
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Both {{FileSystemConfigSetService}} and {{ZkConfigSetService}} only checks 
> the existence of the directory only, if we accidentally create an empty 
> config directory this method returns true, but when we try to use the configs 
> to create a collection we got an error message like this:
> {noformat}
> Can't find resource 'solrconfig.xml' in classpath or '/configs/config_name', 
> cwd=/path/to/lib/solr/server {noformat}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to