janhoy commented on pull request #139: URL: https://github.com/apache/solr/pull/139#issuecomment-854719232
I have now addressed my two points * Create a negative test with a different cert, to see it failing * Remove need for BouncyCastle by importing pcs12 file directly in test I have also added license and sha files for all new test dependencies and made precommit pass. I think this is now ready for review. It's a large PR, but most files are really SHA, LICENSE and NOTICE files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
