janhoy commented on a change in pull request #139:
URL: https://github.com/apache/solr/pull/139#discussion_r646389781
##########
File path:
solr/core/src/java/org/apache/solr/security/JWTVerificationkeyResolver.java
##########
@@ -110,7 +112,13 @@ public Key resolveKey(JsonWebSignature jws,
List<JsonWebStructure> nestingContex
if (issuerConfig.usesHttpsJwk()) {
keysSource = "[" + String.join(", ", issuerConfig.getJwksUrls()) + "]";
for (HttpsJwks hjwks : issuerConfig.getHttpsJwks()) {
- jsonWebKeys.addAll(hjwks.getJsonWebKeys());
+ try {
+ jsonWebKeys.addAll(hjwks.getJsonWebKeys());
+ } catch (SSLHandshakeException e) {
+ log.warn("Failed to talk SSL with {}, do you have the correct SSL
certificate configured?", hjwks.getLocation());
+ throw new SolrException(SolrException.ErrorCode.SERVER_ERROR,
+ "SSL error when validating auth token. Make sure correct
certificates are configured.", e);
Review comment:
Agree, now only throws exception
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
