dsmiley commented on a change in pull request #17:
URL: https://github.com/apache/solr/pull/17#discussion_r651233427
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -370,7 +369,7 @@ public void call(ClusterState clusterState, ZkNodeProps
message, @SuppressWarnin
log.debug("Finished create command on all shards for collection: {}",
collectionName);
// Emit a warning about production use of data driven functionality
boolean defaultConfigSetUsed = message.getStr(COLL_CONF) == null ||
- message.getStr(COLL_CONF).equals(DEFAULT_CONFIGSET_NAME);
+ message.getStr(COLL_CONF).equals(DEFAULT_CONFIGSET_NAME) ||
ConfigSetsHandler.isAutoGeneratedConfigSet(message.getStr(COLL_CONF));
Review comment:
How did the pass test prior then? Which test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
