dsmiley commented on a change in pull request #17:
URL: https://github.com/apache/solr/pull/17#discussion_r655555107
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -560,10 +559,16 @@ public static void
createCollectionZkNode(DistribStateManager stateManager, Stri
}
collectionProps.remove(ZkStateReader.NUM_SHARDS_PROP); // we don't
put numShards in the collections properties
+ collectionProps.remove(ZkStateReader.CONFIGNAME_PROP); // we don't
write configName on a zk collection node
- ZkNodeProps zkProps = new ZkNodeProps(collectionProps);
- stateManager.makePath(collectionPath, Utils.toJSON(zkProps),
CreateMode.PERSISTENT, false);
-
+ if (collectionProps.size() > 0) {
+ ZkNodeProps zkProps = new ZkNodeProps(collectionProps);
+ // create a node with collectionProps data
+ stateManager.makePath(collectionPath, Utils.toJSON(zkProps),
CreateMode.PERSISTENT, false);
Review comment:
Great; lets then not write props since there's nothing there.
##########
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -368,6 +368,7 @@ public void call(ClusterState clusterState, ZkNodeProps
message, @SuppressWarnin
} else {
log.debug("Finished create command on all shards for collection: {}",
collectionName);
// Emit a warning about production use of data driven functionality
+ // AutoGeneratedConfigset is always clone of _default configset
Review comment:
```suggestion
// Note: isAutoGeneratedConfigSet is always a clone of the _default
configset
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
